Fix the nightly grammar validation job - #2347
Merged
Merged
Conversation
This fixes the scheduled job when it was trying the Token permutation. The problem is that proc-macro2 is failing for some inputs. In particular it was having problems with CR in string continuations (dtolnay/proc-macro2#540). There probably should be a better mechanism for identifying inputs that are known to fail and to allow them. This can be difficult with generated inputs since keeping that list up-to-date can be a challenge. It would likely be best to have some automated tooling to help with that. For now, this just disables the proc-macro2 validation for generated Token inputs.
This adds the 3-character Token validation checks. It checks every permutation of characters in the range 0..=0x7F for length one, two, and three. This results in 4,227,328 checks which on my system takes about 22 seconds. On CI it will be much longer, but should be tolerable on a nightly job.
rustbot
added
the
S-waiting-on-review
traviscross
approved these changes
Sep 1, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a fix for the nightly validation job. It also adds a test (the "three" iterator) that I intended to include but forgot.
Closes #2332