-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve f16
and f128
unimplemented!
/FIXME
s
#12950
Conversation
a72f40d
to
af397ce
Compare
Self::F32(f) => { | ||
f64::from(f).to_bits().hash(state); | ||
}, | ||
Self::F64(f) => { | ||
f.to_bits().hash(state); | ||
}, | ||
Self::F128(f) => { | ||
f.to_bits().hash(state); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do here? Functions aren't yet available to convert and use f128
for everything instead.
Marking a draft since I still need to update tests |
08a85ed
to
91a40c1
Compare
I updated the tests to add f16 and f128 everywhere it seemed relevant (i.e. everywhere where both CI testing will continue to fail until the nightly it uses gets bumped to something from the last couple days or newer (after const arithmetic) |
See my comment here: #12952 (comment) TL;DR: I would just include those changes in the Rust PR |
…tations This removes the ICE codepaths for `f16` and `f128`. `rustc_apfloat` is used as a dependency for the parsing of these types, since their `FromStr` implementation will not be available in the standard library for a while.
f16
and f128
unimplemented!
/FIXME
s with real implementationsf16
and f128
unimplemented!
/FIXME
s
Thank you for taking a look!
|
Closing in favor of rust-lang/rust#126636 Thanks for moving it there! |
…flip1995 Resolve Clippy `f16` and `f128` `unimplemented!`/`FIXME`s This was originally a PR against the Clippy repo, rust-lang/rust-clippy#12950 r? `@flip1995` Tracking issue: rust-lang#116909 Fixes: rust-lang#126636
…flip1995 Resolve Clippy `f16` and `f128` `unimplemented!`/`FIXME`s This was originally a PR against the Clippy repo, rust-lang/rust-clippy#12950 r? ``@flip1995`` Tracking issue: rust-lang#116909 Fixes: rust-lang#126636
Rollup merge of rust-lang#126636 - tgross35:clippy-f16-f128-fixme, r=flip1995 Resolve Clippy `f16` and `f128` `unimplemented!`/`FIXME`s This was originally a PR against the Clippy repo, rust-lang/rust-clippy#12950 r? ``@flip1995`` Tracking issue: rust-lang#116909 Fixes: rust-lang#126636
Resolve Clippy `f16` and `f128` `unimplemented!`/`FIXME`s This was originally a PR against the Clippy repo, rust-lang#12950 r? ``@flip1995`` Tracking issue: rust-lang/rust#116909 Fixes: rust-lang/rust#126636
This removes the ICE codepaths for
f16
andf128
.rustc_apfloat
is used as a dependency for the parsing of these types, since theirFromStr
implementation will not be available in the standard library for a while.changelog: make Clippy work correctly with
f16
andf128
(do not merge, contains toolchain updates for testing)