Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent in lints page #13596

Closed
wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 23, 2024

Didn't pay attention that the sanitize_explanation function was trimming lines.

changelog: Fix indent in lints page

r? @flip1995

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 23, 2024
@alex-semenyuk
Copy link
Member

Does it solve the same issue as #13571

@GuillaumeGomez
Copy link
Member Author

Hum. From what I can see, their fix is actually not working. But yes, it's aiming at fixing the same bug.

@flip1995
Copy link
Member

Closing this in favor of #13571 (comment). Should that discussion lead to the outcome, that we want to go with this, we can re-open.

Thanks for addressing my comments so quickly!

@flip1995 flip1995 closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants