Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infinite_loops]: fix incorrect suggestions on async functions/closures #13608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

J-ZhengLi
Copy link
Member

@J-ZhengLi J-ZhengLi commented Oct 26, 2024

closes: #12338

I intend to fix this in #12421 but got distracted by some other problems in the same lint, delaying the process of closing the actual issue. So here's a separated PR that only focus on the issue and nothing else.


changelog: [infinite_loops]: fix suggestion error on async functions/closures

@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 26, 2024
@J-ZhengLi J-ZhengLi changed the title [infinite_loops]: fix suggestion error on async functions/closures [infinite_loops]: fix incorrect suggestions on async functions/closures Oct 26, 2024

/// Return `true` if the given [`FnRetTy`] is never (!).
///
/// Note: This function also take care of return type of async fn,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Note: This function also take care of return type of async fn,
/// Note: This function also takes care of the return type of async fn,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect infinite loop detection in async functions
4 participants