Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for missing_errors_doc at tests with option check-private-item=true #13610

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Oct 27, 2024

Add test case for missing_errors_doc at tests with option check-private-item=true to proof that #13391 is not an issue anymore

changelog: none

Closes: #13391

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2024
@xFrednet
Copy link
Member

Awesome, thank you! :D I've edited the description to also close the issue.


Roses are red,
Violets are blue,
The issue has been fixed,
this just proofs it

@bors
Copy link
Collaborator

bors commented Oct 27, 2024

📌 Commit 900db48 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 27, 2024

⌛ Testing commit 900db48 with merge 31f6679...

@bors
Copy link
Collaborator

bors commented Oct 27, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 31f6679 to master...

@bors bors merged commit 31f6679 into rust-lang:master Oct 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing_errors_doc warns on test functions when check-private-items = true
4 participants