-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #114507 - sebastiantoh:issue-114235, r=jackh726
Add suggestion to quote inlined format argument as string literal Fixes #114235
- Loading branch information
Showing
3 changed files
with
113 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
mod foo { | ||
pub fn bar() -> i32 { | ||
1 | ||
} | ||
} | ||
|
||
fn bar() -> i32 { | ||
2 | ||
} | ||
|
||
fn main() { | ||
let stderr = 3; | ||
eprintln!({stderr}); | ||
//~^ ERROR format argument must be a string literal | ||
//~| HELP quote your inlined format argument to use as string literal | ||
eprintln!({1}); | ||
//~^ ERROR format argument must be a string literal | ||
//~| HELP you might be missing a string literal to format with | ||
eprintln!({foo::bar()}); | ||
//~^ ERROR format argument must be a string literal | ||
//~| HELP you might be missing a string literal to format with | ||
eprintln!({bar()}); | ||
//~^ ERROR format argument must be a string literal | ||
//~| HELP you might be missing a string literal to format with | ||
eprintln!({1; 2}); | ||
//~^ ERROR format argument must be a string literal | ||
//~| HELP you might be missing a string literal to format with | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
error: format argument must be a string literal | ||
--> $DIR/suggest-inline-args.rs:13:15 | ||
| | ||
LL | eprintln!({stderr}); | ||
| ^^^^^^^^ | ||
| | ||
help: quote your inlined format argument to use as string literal | ||
| | ||
LL | eprintln!("{stderr}"); | ||
| + + | ||
|
||
error: format argument must be a string literal | ||
--> $DIR/suggest-inline-args.rs:16:15 | ||
| | ||
LL | eprintln!({1}); | ||
| ^^^ | ||
| | ||
help: you might be missing a string literal to format with | ||
| | ||
LL | eprintln!("{}", {1}); | ||
| +++++ | ||
|
||
error: format argument must be a string literal | ||
--> $DIR/suggest-inline-args.rs:19:15 | ||
| | ||
LL | eprintln!({foo::bar()}); | ||
| ^^^^^^^^^^^^ | ||
| | ||
help: you might be missing a string literal to format with | ||
| | ||
LL | eprintln!("{}", {foo::bar()}); | ||
| +++++ | ||
|
||
error: format argument must be a string literal | ||
--> $DIR/suggest-inline-args.rs:22:15 | ||
| | ||
LL | eprintln!({bar()}); | ||
| ^^^^^^^ | ||
| | ||
help: you might be missing a string literal to format with | ||
| | ||
LL | eprintln!("{}", {bar()}); | ||
| +++++ | ||
|
||
error: format argument must be a string literal | ||
--> $DIR/suggest-inline-args.rs:25:15 | ||
| | ||
LL | eprintln!({1; 2}); | ||
| ^^^^^^ | ||
| | ||
help: you might be missing a string literal to format with | ||
| | ||
LL | eprintln!("{}", {1; 2}); | ||
| +++++ | ||
|
||
error: aborting due to 5 previous errors | ||
|