Handle rustc_metadata cases of rustc::potential_query_instability lint

[ismailarilik]

This PR removes #![allow(rustc::potential_query_instability)] line from compiler/rustc_metadata/src/lib.rs and converts FxHash{Map,Set} types into FxIndex{Map,Set} to suppress lint errors.

A somewhat tracking issue: #84447

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[jieyouxu]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 1b8d81f with merge c27d1bd...

[bors]

☀️ Try build successful - checks-actions
Build commit: c27d1bd (c27d1bd50a3d95971590d5c00927d509fd67c5c8)

[compiler-errors]

Using the insertion order is no worse than using the totally unstable hashing ordering, so this looks fine to me too.

r=me (i.e. I will approve) when perf returns.

[rust-timer]

Finished benchmarking commit (c27d1bd): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results (primary -0.6%, secondary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.5%, 1.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-0.6%	[-3.5%, 1.2%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.256s -> 770.149s (-0.01%)
Artifact size: 341.54 MiB -> 341.54 MiB (-0.00%)

[compiler-errors]

Noise.

@bors r+

[bors]

📌 Commit 1b8d81f has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #131006) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

• 6eba9da

[ismailarilik]

@bors r+

[bors]

@ismailarilik: 🔑 Insufficient privileges: Not in reviewers

[ismailarilik]

@bors rollup

[bors]

@ismailarilik: 🔑 Insufficient privileges: not in try users

[ismailarilik]

@rustbot label S-waiting-on-bors
@rustbot label -S-waiting-on-author

[ismailarilik]

I guess it needs another review.
@rustbot review

[ismailarilik]

@rustbot label -S-waiting-on-bors

[saethlin]

@bors r=compiler-errors

[bors]

📌 Commit 3d8bd6b has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3d8bd6b with merge 9ff5fc4...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 9ff5fc4 to master...

[rust-timer]

Finished benchmarking commit (9ff5fc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.3%, secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.6%, 1.7%]	2
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	2
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-1.5%, 1.7%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.786s -> 773.326s (0.07%)
Artifact size: 342.00 MiB -> 342.03 MiB (0.01%)