Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warning when calling/declaring functions with unavailable vectors. #132173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 31, 2024

  1. Emit warning when calling/declaring functions with unavailable vectors.

    On some architectures, vector types may have a different ABI depending
    on whether the relevant target features are enabled. (The ABI when the
    feature is disabled is often not specified, but LLVM implements some
    de-facto ABI.)
    
    As discussed in rust-lang/lang-team#235, this turns out to very easily
    lead to unsound code.
    
    This commit makes it a post-monomorphization future-incompat warning to
    declare or call functions using those vector types in a context in which
    the corresponding target features are disabled, if using an ABI for
    which the difference is relevant. This ensures that these functions are
    always called with a consistent ABI.
    
    See the [nomination comment](rust-lang#127731 (comment))
    for more discussion.
    
    Part of rust-lang#116558
    veluca93 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d077dd1 View commit details
    Browse the repository at this point in the history