-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some where clause lowering simplifications #132196
base: master
Are you sure you want to change the base?
Some where clause lowering simplifications #132196
Conversation
rustbot has assigned @petrochenkov. Use |
HIR ty lowering was modified cc @fmease |
Are there any observable effects from the second commit? r=me after the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should not have observable changes.
SelfTraitThatDefines
is a filter that is concerned with gathering trait predicates of the form ParamTy: Trait
for a given ParamTy
. We did this previously somewhat haphazardly, both when lowering the bounds, and then re-filtering the bounds again after they've been collected, since the existing predicate filter handling was too lax.
Let me add a debug assertion back that I removed to validate that any further refactorings to the PredicateFilter
s doesn't accidentally reintroduce this behavior.
forgot to flip back to ready: @rustbot ready |
☔ The latest upstream changes (presumably #132377) made this pull request unmergeable. Please resolve the merge conflicts. |
90a6240
to
81dba07
Compare
Rename
PredicateFilter::SelfThatDefines
toPredicateFilter::SelfTraitThatDefines
to make it clear that it's only concerned with converting traits, and make it do a bit less work when converting bounds.Also, make the predicate filter matching in
probe_ty_param_bounds_in_generics
explicit, and simply the args it receives a bit.