Make sin, cos, exp, exp2, log, log2, log10 generic by N1ark · Pull Request #160989 · rust-lang/rust

N1ark · 2026-08-12T14:23:12Z

Rebased and smaller version of #153934

Following fabs, make the sin, cos, exp, exp2, log, log2 and log10 intrinsics generic over the float type, rather than having four variants per float type.

The first two commits are purely stylistic:

reorganised Cranelift code to make following changes simpler
moved a misplaced comment in compiler/rustc_codegen_llvm/src/intrinsic.rs that caused x fmt to give up

The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future bf16 type~~ :)

Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here.

r? @folkertdev
cc @RalfJung

Disclosure: I used an LLM to figure out the macro code.

rustbot · 2026-08-12T14:23:16Z

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

folkertdev · 2026-08-12T14:33:38Z

I suspect it would be better to submit 295e7a3 to the cg_clif repo for better CI coverage.

rustbot · 2026-08-12T14:55:39Z

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

RalfJung

LLVM codegen changes LGTM.
Miri changes are missing, as CI is pointing out. :)
Personally I am fine with these macros, but it's clearly a tradeoff.

View changes since this review

RalfJung · 2026-08-16T18:12:00Z

+   |
+help: consider importing this function
+   |
+LL + use std::intrinsics::log;


This seems like a bad side-effect. Do we have an open issue to track the problem that apparently we recommend importing unstable functions?

not that i could fine, but not sure. agreed this seems pretty bad though, especially for a name as common as log

Hm, something odd is happening -- I don't get similar suggestions for existing intrinsics
Playground

RalfJung · 2026-08-16T18:19:20Z

moved a misplaced comment in compiler/rustc_codegen_llvm/src/intrinsic.rs that caused x fmt to give up

The comment was not misplaced, it was placed exactly where it should be. rustfmt just doesn't like comments in some places so we have to move the comment into a suboptimal place. :(

N1ark · 2026-08-17T08:48:02Z

moved a misplaced comment in compiler/rustc_codegen_llvm/src/intrinsic.rs that caused x fmt to give up

The comment was not misplaced, it was placed exactly where it should be. rustfmt just doesn't like comments in some places so we have to move the comment into a suboptimal place. :(

yes sorry, i meant misplaced from rustfmt's perspective ^^ i agree it's not ideal there, it just seemed clearer than inside the match arm:/

N1ark · 2026-08-17T14:26:55Z

fyi i snuck in sin and cos into the batch because they were the same shape and fit the change really well ^^

N1ark · 2026-08-18T17:38:36Z

@rustbot ready

rustbot · 2026-08-31T17:38:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

N1ark · 2026-08-31T17:40:28Z

@rustbot ready

folkertdev · 2026-09-01T10:06:17Z

@bors r+

rust-bors · 2026-09-01T10:06:20Z

📌 Commit edcae44 has been approved by folkertdev

It is now in the queue for this repository.

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

@folkertdev

…ncs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of rust-lang#153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](rust-lang#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

…uwer Rollup of 16 pull requests Successful merges: - #137720 (support `#[target_feature(enable = ...)]` on `#[naked]` functions) - #160534 (stabilize smart pointer map functions) - #160551 (mir_build: Clearly distinguish or/refutable/irrefutable patterns during match lowering) - #160989 (Make sin, cos, exp, exp2, log, log2, log10 generic) - #161861 (mir_build: Clarify parts of if-condition lowering) - #161929 (explicitly track inherent const generic args kind) - #162040 (bootstrap: stage0 to cbae9b4) - #162063 (Switch dist-aarch64-linux to EC2 and update dist-x86_64-linux) - #161353 (Add test for parallel compiler reproducible build) - #161937 (A series of Polonius Alpha refactors) - #162051 (`rustc_feature` cleanups) - #162055 (remove `_{style}` recovery for diagnostic structs) - #162075 (Move track_caller on closures gating to attribute parsing) - #162079 (std: implement `File::fsync` for Hermit) - #162097 (Deduplicate `InstrumentFnAttr`) - #162115 (fix typo in feature documentation)

@folkertdev

Rollup merge of #160989 - N1ark:08-12-generic-float-intrinsincs, r=folkertdev Make sin, cos, exp, exp2, log, log2, log10 generic Rebased and smaller version of #153934 Following `fabs`, make the `sin`, `cos`, `exp`, `exp2`, `log`, `log2` and `log10` intrinsics generic over the float type, rather than having four variants per float type. The first two commits are purely stylistic: - reorganised Cranelift code to make following changes simpler - moved a misplaced comment in `compiler/rustc_codegen_llvm/src/intrinsic.rs` that caused `x fmt` to give up The last commit actually makes them generic! Most code is a bit simpler, ~~and this will also hopefully simplify adding support for these intrinsics for the future [`bf16` type](#160859 :) Unfortunately both GCC and Cranelift backend changes are a bit churny. Their code is a bit, opaque, to put it kindly, and I didn't want to refactor those here. r? @folkertdev cc @RalfJung

rust-timer · 2026-09-01T18:10:47Z

Finished benchmarking commit (3d12069): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.2%	[0.1%, 0.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.9%, -0.4%]	2
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.6%, -0.9%]	5
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 400.59 MiB -> 400.58 MiB (-0.00%)

…uwer Rollup of 16 pull requests Successful merges: - rust-lang/rust#137720 (support `#[target_feature(enable = ...)]` on `#[naked]` functions) - rust-lang/rust#160534 (stabilize smart pointer map functions) - rust-lang/rust#160551 (mir_build: Clearly distinguish or/refutable/irrefutable patterns during match lowering) - rust-lang/rust#160989 (Make sin, cos, exp, exp2, log, log2, log10 generic) - rust-lang/rust#161861 (mir_build: Clarify parts of if-condition lowering) - rust-lang/rust#161929 (explicitly track inherent const generic args kind) - rust-lang/rust#162040 (bootstrap: stage0 to cbae9b4cae2b108f6a3d18cfe6075714bb739463) - rust-lang/rust#162063 (Switch dist-aarch64-linux to EC2 and update dist-x86_64-linux) - rust-lang/rust#161353 (Add test for parallel compiler reproducible build) - rust-lang/rust#161937 (A series of Polonius Alpha refactors) - rust-lang/rust#162051 (`rustc_feature` cleanups) - rust-lang/rust#162055 (remove `_{style}` recovery for diagnostic structs) - rust-lang/rust#162075 (Move track_caller on closures gating to attribute parsing) - rust-lang/rust#162079 (std: implement `File::fsync` for Hermit) - rust-lang/rust#162097 (Deduplicate `InstrumentFnAttr`) - rust-lang/rust#162115 (fix typo in feature documentation)

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Aug 12, 2026

rustbot assigned folkertdev Aug 12, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 12, 2026

This comment has been minimized.

Sign in to view

N1ark force-pushed the 08-12-generic-float-intrinsincs branch from d98ca71 to b3a59f6 Compare August 12, 2026 14:55

rustbot added the T-clippy Relevant to the Clippy team. label Aug 12, 2026

This comment has been minimized.

Sign in to view

bjorn3 reviewed Aug 12, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026

RalfJung reviewed Aug 16, 2026

View reviewed changes

N1ark force-pushed the 08-12-generic-float-intrinsincs branch 2 times, most recently from 88ea1bd to 01eda22 Compare August 17, 2026 14:22

N1ark changed the title ~~Make exp, exp2, log, log2, log10 generic~~ Make sin, cos, exp, exp2, log, log2, log10 generic Aug 17, 2026

This comment has been minimized.

Sign in to view

N1ark force-pushed the 08-12-generic-float-intrinsincs branch from 01eda22 to ccd0e63 Compare August 18, 2026 12:30

This comment has been minimized.

Sign in to view

N1ark force-pushed the 08-12-generic-float-intrinsincs branch from ccd0e63 to 9878ba8 Compare August 18, 2026 12:34

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 28, 2026

Cleanup cranelift codegen_float_intrinsic_call

3ba7833

N1ark force-pushed the 08-12-generic-float-intrinsincs branch from 9878ba8 to 451f25e Compare August 31, 2026 17:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2026

This comment has been minimized.

Sign in to view

N1ark added 2 commits August 31, 2026 18:57

Fix misplaced comment

b95e309

Make sin, cos, exp, exp2, log, log2, log10 generic

edcae44

N1ark force-pushed the 08-12-generic-float-intrinsincs branch from 451f25e to edcae44 Compare August 31, 2026 17:57

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026

JonathanBrouwer mentioned this pull request Sep 1, 2026

Rollup of 16 pull requests #162117

Merged

rust-bors Bot merged commit f909000 into rust-lang:main Sep 1, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 1, 2026

Uh oh!

Uh oh!

Conversation

N1ark commented Aug 12, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 12, 2026

Uh oh!

folkertdev commented Aug 12, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 12, 2026

Uh oh!

This comment has been minimized.

Uh oh!

RalfJung left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RalfJung Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

N1ark Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

RalfJung commented Aug 16, 2026

Uh oh!

N1ark commented Aug 17, 2026

Uh oh!

N1ark commented Aug 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

N1ark commented Aug 18, 2026

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

N1ark commented Aug 31, 2026

Uh oh!

This comment has been minimized.

folkertdev commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 1, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

N1ark commented Aug 12, 2026 •

edited by rustbot

Loading

RalfJung left a comment •

edited by rustbot

Loading