-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track if a where bound comes from a impl Trait desugar #96770
Conversation
This reverts commit bb01aca. Partial: Keep regression tests
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
r=me after addressing cjgillot's comment |
bfa15d6
to
65e38fa
Compare
With rust-lang#93803 `impl Trait` function arguments get desugared to hidden where bounds. However, Clippy needs to know if a bound was originally a impl Trait or an actual bound. This adds a field to the `WhereBoundPredicate` struct to keep track of this information during HIR lowering.
65e38fa
to
dd1ff40
Compare
I think I addressed everything. |
@bors r+ |
📌 Commit dd1ff40 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ed3164b): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
…cjgillot Track if a where bound comes from a impl Trait desugar With rust-lang#93803 `impl Trait` function arguments get desugared to hidden where bounds. However, Clippy needs to know if a bound was originally a `impl Trait` or an actual bound. This adds a field to the `WhereBoundPredicate` struct to keep track of this information during AST->HIR lowering. r? `@cjgillot` cc `@estebank` (as the reviewer of rust-lang#93803)
With #93803
impl Trait
function arguments get desugared to hidden where bounds. However, Clippy needs to know if a bound was originally aimpl Trait
or an actual bound. This adds a field to theWhereBoundPredicate
struct to keep track of this information during AST->HIR lowering.r? @cjgillot
cc @estebank (as the reviewer of #93803)