run unittests in privileged docker container #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code coverage tests already run in a privileged container, so this does not affect our security posture. Additionally, it will unblock vsock unit tests in the vhost-user-vsock crate, see also rust-vmm/vhost-device#706 and rust-vmm/vhost-device#728 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
requested review from
andreeaflorescu,
lauralt,
sameo and
ShadowCurse
as code owners
|
I was about to ask if we could do the same for I will bring up this discussion recently :) |
stefano-garzarella
approved these changes
Sep 27, 2024
lauralt
reviewed
Oct 4, 2024
lauralt
approved these changes
Oct 9, 2024
stefano-garzarella
added a commit
to stefano-garzarella/vhost-device
that referenced
this pull request
Oct 10, 2024
rust-vmm/rust-vmm-ci#165 allows us to run unittests in a privileged container, so we can use AF_VSOCK in our CI which was otherwise not allowed by docker. This was already enabled for coverage tests. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
|
Just to confirm that now rust-vmm/vhost-device#728 is working great with this PR merged! |
vireshk
pushed a commit
to rust-vmm/vhost-device
that referenced
this pull request
Oct 10, 2024
rust-vmm/rust-vmm-ci#165 allows us to run unittests in a privileged container, so we can use AF_VSOCK in our CI which was otherwise not allowed by docker. This was already enabled for coverage tests. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code coverage tests already run in a privileged container, so this does not affect our security posture. Additionally, it will unblock vsock unit tests in the vhost-user-vsock crate, see also rust-vmm/vhost-device#706 and rust-vmm/vhost-device#728
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.