-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sound: fix broken tests #496
Conversation
LGTM, I just saw a drop in coverage, maybe related to #487 or #445 :
@dorindabassey can you take a look at pipewire tests changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe I read it wrong, but isn't it an increased coverage? |
Oooo, right! |
Yeah, the
I can send a quick PR :) |
yeah!
Maybe it's useful to remind us to update the file, otherwise if it grows and we don't update the file, then it decreases, we won't notice the difference.
Thanks! |
Right, but it may set the coverage bar higher for new crates compared to the ones already integrated. But I understand the reasoning, it is ok. Thanks for explaining :) |
This is true, but we are open to dropping it for good reasons. We use it more as a way to remind ourselves to update it ;-) |
Tests were not updated with changes in previous commits, so update them. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Rebased |
Tests were not updated with changes in previous commits, so update them.
See #493 (comment)