Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: Calculate ime cursor position correctly. #3966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xorgy
Copy link

@xorgy xorgy commented Oct 23, 2024

Fixes #3965

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally not correct, though, since the intended way to do is to pass an area that shouldn't be obscured rather than offset. The concepts are different here, I'd say.

Probably something from XNPreeditArea is how it should work.

I generally won't block this patch, but it should be mentioned in the docs what it does and probably we should suggest to pass just a line generally for cursor to not hit bugs in various setups.

@xorgy
Copy link
Author

xorgy commented Oct 24, 2024

That's fair, I can add documentation changes to that effect, and a couple comments in the backend mentioning other possible ways to do preedit area reports (though I haven't found any IM servers implementing PreeditArea so far).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

set_ime_cursor_area uses the top left corner of the rectangle as the composition/cursor point on X11
2 participants