-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.12.0 release planning #199
Comments
What would be the "cost" of doing multiple smaller releases compared to one big release? In general, I prefer smaller but more often releases than less often and bigger releases. Thus I would be in favor of 1). |
Yeah, I think it makes sense to do a smaller release sooner. Personally I would be motivated to get the pki-types + rustls-pemfile transition in soon if we're agreed that that is the right path forward. Maybe we should also get #62 in since it might need a fairly involved API change and is a bit of a footgun? |
I also prefer multiple smaller releases over few big ones. I don't think we need to wait for #170. #190 would be nice but if we can't get it merged this week we should just make the 0.12.0 release without it (it's a separate crate anyways, we should probably talk about the release schedule of that one, should it be always aligned with rcgen, should it follow a different schedule, etc). |
Great, so it sounds like everyone would favour getting a release out sooner than later 👍
It looks like #190 will land once the OP addresses the last couple small comments. Not including #170 sounds fine to me.
I agree, but also haven't tried to come up with a better design yet. I think it would be helpful to have some proposals in-hand to decide whether it seems likely we can turn around the fix quickly or if it will take longer in review to arrive at a replacement everyone likes. |
I have added a comment to #62 for my proposed solution. It does need an API change that is a bit involved. We can also nudge people to the new API however via |
Can we make 0.12 on the weekend? I prefer not to wait with this too much. We can do 0.13 at any time when we feel ready. |
The changelog update is done quickly, I offer to do it. I think for users it's quite useful to be able to use ring 0.17 sooner rather than later, or not even use ring at all if they wish so. Then after the release, we can work on 0.13 without pressure. Pressure is not good :). |
Ok, you make a good point :-) SGTM |
For release notes see the changelog. fixes #199 --------- Co-authored-by: Daniel McCarney <daniel@binaryparadox.net>
can we add #157 to 0.12 now that it's passing? |
I think it makes sense to try and land #157. It looks like there are some new suggestions on that branch to make review easier. If merged it would be included in a new 0.13 release alongside other breaking changes in |
Let's gather some context for release planning since there have been a few requests.
Some items that are close to being done that I think we should block on:
rustls-cert-gen
with basic parameters. #190 - requires additional maintainer review.Refactoredit: consensus here is to skip this one.KeyPair
constructor #170 - requires update for review feedback.Some items that will require a major version increase that are not as close to being completed:
pki-types
andrustls-pemfile
- unstarted - needs discussion.In my view there's a good amount of work left to do that will require a comparable version bump. I think this means we have a choice between:
The text was updated successfully, but these errors were encountered: