-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.12.0 #202
Release 0.12.0 #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together 👍
Co-authored-by: Daniel McCarney <daniel@binaryparadox.net>
There is no changes to the version in |
As a small note, in the future I'd like a chance to approve the changelog before the release is published if I leave feedback. If I don't reply right away it seems reasonable to roll forward without waiting.
That sounds fine to me. In the other Rustls repos we tend to use -alpha.0 but I don't feel strongly. |
Sorry, noted! |
From the release 0.12 of rcgen #202 , we must now choose `ring` or `aws_lc_rc` as a feature. Because `rustls_cert_gen` has `default-features = false`, its build is currently broken. This PR activate `aws_lc_rc` feature, because soon it will get RSA key generation support aws/aws-lc-rs#296 , so it will provide more options. But we could also change it to default to whatever `rcgen` default or use `ring` as default depending on your preferences.
For release notes see the changelog.
fixes #199