Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch-up CI to closer match Rustls CI #85

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented Nov 30, 2023

I think this repo's CI configuration hasn't seen as much love as some of the other Rustls repos. This branch is a quick tune-up adding some things that we've found helpful in other repos. Best reviewed commit-by-commit.

After this lands I'll update the branch protection rules and enable the merge queue feature.

* Run for 'merge_group' to support the merge queue feature.
* Add a cron scheduled run to prevent bitrot during periods of
  inactivity.
@cpu cpu self-assigned this Nov 30, 2023
@cpu
Copy link
Member Author

cpu commented Nov 30, 2023

rustls / msrv (ubuntu-20.04) (pull_request) In progress — This check has started...
rustls / msrv (macos-latest) (pull_request) In progress — This check has started...
rustls / msrv (windows-latest) (pull_request) In progress — This check has started...

Over in rustls/rustls we only check MSRV on Ubuntu 20.04. Should this repo do the same? It will save some CI time.

.github/workflows/rust.yml Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
This matches updated guidance from the Rust project that libraries
_should_ check in their lockfile. Also updates CI to use `--locked`
where appropriate.
@ctz
Copy link
Member

ctz commented Dec 1, 2023

Should this repo do the same? It will save some CI time.

I think the code being compiled in this repo differs quite a bit by platform; whereas in rustls there is ~zero platform-specific code.

@cpu
Copy link
Member Author

cpu commented Dec 1, 2023

I think the code being compiled in this repo differs quite a bit by platform; whereas in rustls there is ~zero platform-specific code.

That makes sense, I'll leave it as-is.

@cpu cpu merged commit 69e6f29 into rustls:main Dec 1, 2023
13 checks passed
@cpu cpu deleted the cpu-ci-tuneup branch December 1, 2023 17:23
@cpu
Copy link
Member Author

cpu commented Dec 1, 2023

Updated the branch protection rules to require each CI task pass, usage of the merge queue with the rebase+merge strat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants