Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run audit on examples #3508

Merged

Conversation

Stefan-Hanke
Copy link
Contributor

If this PR is merged, it will update and cleanup the package.json files in the examples.

More specifically, I ran for d in $(ls); do cd $d; npm i; npm audit fix --force; cd -; done from the examples folder.

The command not only updated webpack-dev-server but also seemed to have reordered the entries (sorting them alphabetically) and did a minor reformatting (dropped a superfluous whitespace), but that looks ok IMO.

I did run npm run build followed by npm run serve on the add example to verify that it's still working as expected.

@Stefan-Hanke
Copy link
Contributor Author

Fortunately the examples are built from the build_examples job.

Unfortunately those grep -v stuff seemed to not have been updated in lieu with changes of the folder names, e.g. there is also a grep -v raytrace but the directory is called raytrace-parallel oh well it's a grep so it runs fine. It just looks a bit odd...

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's appreciated!

@daxpedda daxpedda merged commit e13d898 into rustwasm:main Jul 5, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants