Add num_points to fps as an alternative to ratio #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 97.32% 97.52% +0.19%
==========================================
Files 11 11
Lines 224 242 +18
==========================================
+ Hits 218 236 +18
Misses 6 6 ☔ View full report in Codecov by Sentry. |
LarsHaalck
force-pushed
the
master
branch
2 times, most recently
from
5657169
to
d552641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of farthest point sampling only allows to set a ratio value to define the number of output points. Some use-cases require a fixed number of output points.
This PR adds an argument
num_pointsto allow this. I also added some tests. The implementation raises a runtime exception if the number of requested points is greater than the number of input points.