Fix the number of neighbors bug in radius_graph
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuangui Huang <xuanguih@nvidia.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 97.32% 97.28% -0.04%
==========================================
Files 11 11
Lines 224 221 -3
==========================================
- Hits 218 215 -3
Misses 6 6 ☔ View full report in Codecov by Sentry. |
rusty1s
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the bug in Issue #219 .
An optional parameter
ignore_same_indexis added to the end of the parameters list ofradius, so that it doesn't break existing codes.Unit tests are added to test for the bug in non-batched mode and batched mode, and when there are coincident points.