Add a second partion to allow user settings to persist between firmware updates #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should help with debugging
the readsettings function would recurse indefinately if writesettings would not generate a file. However, default settings are included in the main firmware header so there is no real need to write them if settings.ini does not exist. We can just write the settings when they change.
the fucntion getUniqueID() depends on networkstuff.h so the definition of MQTT variables is moved below this include, to allow settingMQTTuniqueid to be set from the start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of changes in this pull request but I have tried to separate them into managable commits as best as possible.
As a final test before creating this pull request I reflashed to the 0.9.3 release and littlefs and then applied the new build OTA. This worked flawlessly but it is important that the firmware is flashed first otherwise everything needs to be reflashed through USB.
There is an included batch file which should be used to build the littlefs.bin from this change on. Any parameters changed in this build script would also need to be changed in OTGW-firmware.ino (page size, fs size etc.) For now I have set the systemFS to 1 megabyte but this can be increased to 1.5m fairly easily and without impacting user settings. Flashing the orginal littlefs.bin would override the user partition but should still work.
I have made a few changes to the settings handling as well since some undesirable behaviour showed up while testing my code with failing filesystems. Hope you don't mind.