Update dockerfiles #701
Update dockerfiles #701
Conversation
thatnerdjosh
commented
Jan 29, 2024
•
thatnerdjosh
commented
- Convert line endings for some files
- Install newer CMake as per CMakeList requirements.
- Update repository reference
- Migrate from deprecated MAINTAINER command.
- Add insert_final_newline
- Add end_of_line setting
thatnerdjosh
force-pushed
the
support/update_dockerfiles
branch
from
3f5f272
to
3913aba
Compare
| @@ -1,6 +1,10 @@ | |||
| ; Top-most EditorConfig file | |||
| root = true | |||
|
|
|||
| [*] | |||
| insert_final_newline = true | |||
| end_of_line = lf | |||
There was a problem hiding this comment.
All our line endings are set to platform native in git configuration.
There was a problem hiding this comment.
Ok - the issue I was having is most files were checked in LF, but there were some files which were CRLF in the repo, which caused the branch to be dirty immediately on checkout. Do you have a solution for this?
There was a problem hiding this comment.
Yes, they should be in LF in the repo, so committing the LF files is the correct fix for that. Just local storage should be in native.
See https://github.com/ryzom/ryzomcore/blob/core4/.gitattributes
There was a problem hiding this comment.
Those defective files might've been committed before the .gitattributes was cleaned up.
There was a problem hiding this comment.
Amazing - I'll remove this editorconfig change then as it's not necessary
