Skip to content

Commit

Permalink
Simplify the wad class hierarchy a bit
Browse files Browse the repository at this point in the history
Since before this change all subclasses of NON-CST-WAD "added back" WAD as a
superclass, change the superclass of NON-CST-WAD from BASIC-WAD to WAD. The only
"non-proper" wad class (that is, a class which has BASIC-WAD instead of WAD as
its direct superclass) is now ERROR-WAD.
  • Loading branch information
scymtym committed Jun 16, 2024
1 parent 5f7a066 commit 87ac6d5
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions code/wad.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -452,10 +452,10 @@

;;; Non-CST wads

(defclass non-cst-wad (basic-wad)
(defclass non-cst-wad (wad)
())

(defclass skipped-wad (non-cst-wad wad)
(defclass skipped-wad (non-cst-wad)
())

;;; This class is the base class of all comment wads.
Expand Down Expand Up @@ -534,8 +534,7 @@
;;; `text-wad' does not have any children.

(defclass text-wad (no-children-mixin
non-cst-wad
wad) ; TODO should not inherit indentation
non-cst-wad) ; TODO should not inherit indentation
())

(defclass punctuation-wad (text-wad)
Expand Down

0 comments on commit 87ac6d5

Please sign in to comment.