Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Changes for v1.4.1-2 cherry picked from release/v1.4.1-2 #815

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Audit Changes for v1.4.1-2 cherry picked from release/v1.4.1-2 #815

merged 2 commits into from
Sep 9, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Aug 28, 2024 •
edited
Loading

This PR makes the changes based on Certora's audit report from the branch release/v1.4.1-2 to main.

In the release branch, we used the ISafe contract written inside the respective library files, but with main, we use the ISafe standard interface in the interfaces folder. Similarly, Enum was moved from common to libraries, and thus that is used for the same in the migration contracts.

Note: A fmt change was made to DebugTransactionGuard.sol.

@remedcu
Audit Changes for v1.4.1-2 (#812)
44aa3ac 
This PR makes the changes based on Certora's audit report for the Safe
Migration Contracts. Changes are only made to the `SafeToL2Migration`
contract. Most of the changes are related to reducing gas consumption,
typos and comments.
@remedcu remedcu self-assigned this Aug 28, 2024
@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10597342302

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 93.571%
Totals Coverage Status
Change from base Build 10451906756: 0.09%
Covered Lines: 396
Relevant Lines: 408
💛 - Coveralls

mmv08
mmv08 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(make sure to not squash the commit, because it'll create a new one)

@remedcu
Copy link
Member Author

remedcu commented Aug 28, 2024

(make sure to not squash the commit, because it'll create a new one)

The commit SHA is already different because of the changes mentioned in the description.

Original Commit SHA: 75018fb

@remedcu remedcu mentioned this pull request Aug 28, 2024
Merged
remedcu added a commit that referenced this pull request Aug 28, 2024
@remedcu
Removing payable (#817)
b541cd7 
This PR removes the `payable` casting based on the comment
#815 (comment)
@nlordell
Copy link
Collaborator

(make sure to not squash the commit, because it'll create a new one)

I think its fine to squash commit. We have to re-audit for 1.5.0 anyway.

@remedcu remedcu merged commit 786dadc into main Sep 9, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@mmv08 mmv08 deleted the library-audit branch September 9, 2024 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@akshay-ap akshay-ap akshay-ap approved these changes

@mmv08 mmv08 mmv08 approved these changes

Assignees

@remedcu remedcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@remedcu @coveralls @nlordell @akshay-ap @mmv08