Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #816

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Update CHANGELOG.md #816

merged 8 commits into from
Sep 6, 2024

Conversation

akshay-ap
Copy link
Member

Fixes #790

Changes in PR:

  • Mention new added contracts: SafeMigration and SafeToL2Setup
  • Mention new module guard interface IModuleGuard
  • Update expected contract addresse

@akshay-ap akshay-ap self-assigned this Aug 28, 2024
@akshay-ap akshay-ap marked this pull request as draft August 28, 2024 10:17
@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10630626622

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.478%

Totals Coverage Status
Change from base Build 10613396108: 0.0%
Covered Lines: 386
Relevant Lines: 398

💛 - Coveralls

@akshay-ap akshay-ap marked this pull request as ready for review August 28, 2024 12:06
CHANGELOG.md Show resolved Hide resolved
@mmv08
Copy link
Member

mmv08 commented Aug 28, 2024

In my understanding, the new migration contracts will be released as an incremental release of 1.4.1 (1.4.1-3 or something similar) and not as part of 1.5.0.

If we decide to release it as part of 1.5.0, that means we released a version without providing an upgrade mechanism, so I believe the migration contract should be part of the 1.4.1 changelog. I'm not sure about the SafeToL2Setup, but I think it's alright if we do it in 1.4.1 as well.

@akshay-ap
Copy link
Member Author

In my understanding, the new migration contracts will be released as an incremental release of 1.4.1 (1.4.1-3 or something similar) and not as part of 1.5.0.

If we decide to release it as part of 1.5.0, that means we released a version without providing an upgrade mechanism, so I believe the migration contract should be part of the 1.4.1 changelog. I'm not sure about the SafeToL2Setup, but I think it's alright if we do it in 1.4.1 as well.

Fine with moving to 1.4.1.
cc @nlordell

@akshay-ap akshay-ap requested a review from remedcu August 29, 2024 10:06
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
akshay-ap and others added 2 commits August 30, 2024 11:53
Co-authored-by: Nicholas Rodrigues Lordello <n@lordello.net>
Co-authored-by: Nicholas Rodrigues Lordello <n@lordello.net>
@akshay-ap akshay-ap requested a review from remedcu August 30, 2024 10:10
@akshay-ap akshay-ap merged commit 2787247 into main Sep 6, 2024
19 of 20 checks passed
@akshay-ap akshay-ap deleted the fix-790-update-changelog branch September 6, 2024 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Changelog
5 participants