Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/main.yml: Add portability/integration testing with Sage #140

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Oct 4, 2023

We use the reusable workflows from Sage to test portability and integration with Sage.

@mkoeppe mkoeppe self-assigned this Oct 4, 2023
@mkoeppe mkoeppe force-pushed the ci_sage branch 8 times, most recently from 5e9a21f to a520e8c Compare October 4, 2023 21:23
@mkoeppe mkoeppe added this to the 2.1.4 milestone Oct 6, 2023
@mkoeppe
Copy link
Author

mkoeppe commented Oct 6, 2023

rebased

@dimpase
Copy link
Member

dimpase commented Oct 6, 2023

I guess this has to wait until Sage's CI is in order.

@mkoeppe
Copy link
Author

mkoeppe commented Oct 6, 2023

@videlec @dimpase Ready for merging.

@dimpase
Copy link
Member

dimpase commented Oct 8, 2023

Don't we want docs/Makefile and docs/source/ in MANIFEST.in ?

@mkoeppe
Copy link
Author

mkoeppe commented Oct 8, 2023

Let's keep this PR focused on what is in its title please.

@dimpase
Copy link
Member

dimpase commented Oct 9, 2023

I am asking a legitimate question - you added a Makefile to Manifest, I wonder whether there are more Makefiles etc that should be added.

@mkoeppe
Copy link
Author

mkoeppe commented Oct 9, 2023

I am asking a legitimate question - you added a Makefile to Manifest, I wonder whether there are more Makefiles etc that should be added.

In this PR, no, because Sage does not do anything with cypari2 documentation.

Otherwise, also no, because when you install using pip from an sdist, the documentation is not to be built. This is something that developers would do directly in a git tree.

@dimpase dimpase merged commit 57ab63c into sagemath:master Oct 9, 2023
86 of 100 checks passed
@dimpase
Copy link
Member

dimpase commented Oct 9, 2023

OK, fine

@mkoeppe mkoeppe deleted the ci_sage branch October 9, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants