-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the output of method acyclic_orientations
#38757
fix the output of method acyclic_orientations
#38757
Conversation
Documentation preview for this PR (built with commit 8e7f772; changes) is ready! 🎉 |
Not checking asksage, I've opened #38758 to consider a bigger change. |
can we have a shorter doctest - there is no need to list all these 18 things. Instead, something like
|
(I have edited my answer): yes, we can do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from a shorter doctest, could you also put the link to askbot in the commit message, and a short explainer?
other than that, good to go |
I'm not sure to get what you ask for. I can ask a link to this PR |
perhaps also something like "return a properly relabeled digraph, not just the arc labeling to describe the orientation" ? |
regarding the commit message, I meant the attached, to replace the branch here |
return a properly relabeld digraph, not just the arc labeling to describe the orientation.
434f152
to
8e7f772
Compare
This PR fixes the issue with the output of method `acyclic_orientations` reported in https://ask.sagemath.org/question/79427/the-acyclic- orientations-function-behaves-unexpectedly/. Now the method outputs digraphs with the correct orientation of the arcs. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38757 Reported by: David Coudert Reviewer(s): Dima Pasechnik
This PR fixes the issue with the output of method `acyclic_orientations` reported in https://ask.sagemath.org/question/79427/the-acyclic- orientations-function-behaves-unexpectedly/. Now the method outputs digraphs with the correct orientation of the arcs. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38757 Reported by: David Coudert Reviewer(s): Dima Pasechnik
This PR fixes the issue with the output of method
acyclic_orientations
reported in https://ask.sagemath.org/question/79427/the-acyclic-orientations-function-behaves-unexpectedly/.Now the method outputs digraphs with the correct orientation of the arcs.
📝 Checklist
⌛ Dependencies