Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/angular 14 #1038

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Fix/angular 14 #1038

merged 2 commits into from
Dec 13, 2022

Conversation

nerumo
Copy link
Contributor

@nerumo nerumo commented Dec 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Akita is incompatibility with the last Typescript version, 4.8, used on NX and Angular 14 by default.

Issue Number: #870

What is the new behavior?

Akita can be used on typescript 4.8

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

NX workspace had to be updated, it changes somes config file slightly.

Update NW workspace to version 14 upgrading angular to the same version and typescript up to 4.8

Closes salesforce#870
@salesforce-cla
Copy link

salesforce-cla bot commented Dec 9, 2022

Thanks for the contribution! Before we can merge this, we need @nerumo to sign the Salesforce.com Contributor License Agreement.

@nerumo
Copy link
Contributor Author

nerumo commented Dec 9, 2022

image

what's going with the salesforce CLA?

Fixes a test that seems to be affected by the decorator emission after the upgrade
@corsairdnb
Copy link

@NetanelBasal Could you please pay attention to this PR?
The issue prevents us from using Akita with latest Typescript and Angular versions, so it's crucial to be fixed ASAP.
Thank you!

@acn-masatadakurihara
Copy link

@salesforce-datorama-checkmarx
This package that your company manage is in a poor state of maintenance, leaving vulnerabilities in the dependencies package, not keeping up with the latest version of Angular, and not being appropriate as OSS.
Please review your management system.

#1037

@jimjag jimjag merged commit 4cc4d9a into salesforce:master Dec 13, 2022
@nerumo nerumo deleted the fix/angular-14 branch December 14, 2022 21:20
@corsairdnb
Copy link

@jimjag Thank you for merging this! How can we get the new version released on npm?

@arizmendiomar
Copy link

Any news about a new release?
Does someone knows to whom do we need to reach out to get a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants