refactor(general): use relative import #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Den-dp the build is failing. |
Using relative paths within the same project prevents circular self dependency. It strikes when f.e. you configure your tsconfig.base to use `dist` instead of `src`, because in such case `jest` will not be able to import it (so this test will fail)
Den-dp
force-pushed
the
refactor/use-relative-import
branch
from
d12a550
to
e673136
Compare
|
@NetanelBasal sure, was waiting for 5610f55 to be merged. I've rebased it and now it's green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The issue can be experienced only when switching your tsconfig.base paths to use
distinstead ofsrc(that is what I have tried to do in this repo while working on #1050), because in such casejestwill not be able to import it (so this test fails)What is the new behavior?
Using relative paths within the same project prevents circular self-dependency
Does this PR introduce a breaking change?