fix: support context switching for wrapped Appium drivers on hybrid mobile apps (@W-23972736) - #245
Open
mnagamalla1 wants to merge 1 commit into
Open
Conversation
…ching UTAM's WebDriverFactory.getAdapter chose WrappedDriverAdapter (web-only) for any WrappedDriverDecorator, even when the underlying WebDriver was an AppiumDriver. Mobile context switching (mobile: getContexts, SupportsContextSwitching) is only performed by MobileDriverAdapter, so wrapped Appium drivers never switched into the post-login WebView on hybrid apps. Changes: - WebDriverFactory.getAdapter checks WrappedDriverDecorator first; if the unwrapped driver is an AppiumDriver, returns the new WrappedMobileDriverAdapter. - WrappedMobileDriverAdapter extends MobileDriverAdapter. getSeleniumDriver() returns the wrapped driver (so findElement flows through any wrapper-side smart finder); getAppiumDriver() returns the unwrapped AppiumDriver (so context switching operates on the real driver). - MobileDriverAdapter.getAppiumDriver(): final -> protected, package-private -> protected, so subclasses in other packages can override. - WrappedElementAdapter constructor accepts DriverAdapter (was WrappedDriverAdapter) so it works with both web and mobile wrapped variants. Bumps version to 4.0.7-mobile-rtl-SNAPSHOT. All 385 existing utam-core unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebDriverFactory.getAdapterchoseWrappedDriverAdapter(web-only) for anyWrappedDriverDecorator, even when the underlyingWebDriverwas anAppiumDriver. Mobile context switching (mobile: getContexts,SupportsContextSwitching) is only performed byMobileDriverAdapter, so wrapped Appium drivers never switched into the post-login WebView on hybrid apps.Changes
WebDriverFactory.getAdapterchecksWrappedDriverDecoratorfirst; if the unwrapped driver is anAppiumDriver, returns the newWrappedMobileDriverAdapter.WrappedMobileDriverAdapterextendsMobileDriverAdapter.getSeleniumDriver()returns the wrapped driver (sofindElementflows through any wrapper-side smart finder);getAppiumDriver()returns the unwrappedAppiumDriver(so context switching operates on the real driver).MobileDriverAdapter.getAppiumDriver():final-> non-final, package-private ->protected, so subclasses in other packages can override.WrappedElementAdapterconstructor acceptsDriverAdapter(wasWrappedDriverAdapter) so it works with both web and mobile wrapped variants.Test plan
@W-23972736