Skip to content

Commit

Permalink
Explicitly build in release mode
Browse files Browse the repository at this point in the history
Builds are failing with protobuf 3.20.1 at runtime with
ImportError: libimp_npctransport.so.0: undefined symbol:
_ZN6google8protobuf8internal16InternalMetadataD1Ev

This appears to be because protobuf was built in release
mode (with NDEBUG defined) but we are (perhaps) building
in debug mode (without NDEBUG). Relates
conda-forge/ctng-compiler-activation-feedstock#73.
  • Loading branch information
benmwebb committed Jun 3, 2022
1 parent 8281a86 commit 30d80a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
source ${CONDA_PREFIX}/etc/conda/activate.d/activate-gxx_linux-64.sh
mkdir build && cd build
if test "${{ matrix.python-version }}" = "2.7" ; then PY2=on; else PY2=off; fi
cmake .. -DIMP_DIR=${CONDA_PREFIX}/lib/cmake/IMP -DUSE_PYTHON2=${PY2} -DCMAKE_CXX_FLAGS="-fprofile-arcs -ftest-coverage" -DAVROCPP_INCLUDE_PATH=~/rmf/src/avrocpp/api
cmake .. -DCMAKE_BUILD_TYPE=Release -DIMP_DIR=${CONDA_PREFIX}/lib/cmake/IMP -DUSE_PYTHON2=${PY2} -DCMAKE_CXX_FLAGS="-fprofile-arcs -ftest-coverage" -DAVROCPP_INCLUDE_PATH=~/rmf/src/avrocpp/api
make
./setup_environment.sh pytest --cov=.. --cov-branch --cov-report=xml -v -k 'not test_protobuf_installed and not add_test_sites' ../test/test_*.py ../test/medium_test_*.py test/*/*.py
flake8 ../pyext/src/
Expand Down

0 comments on commit 30d80a3

Please sign in to comment.