Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling for TransportQueryError #65

Merged

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented Aug 18, 2023

Fixes #64 ... although maybe not in the most appropriate way 😄

I'm just taking a stab at this without knowing much about the Python conventions for error handling... or even why the error has only occured in the last week.

Copy link
Contributor

@yusufhm yusufhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @GROwen, looks good!

I just added a comment and suggestion for the KeyError|TypeError exception case.

api/plugins/action/project.py Outdated Show resolved Hide resolved
Co-authored-by: Yusuf A. Hasan Miyan <yusuf.hasanmiyan@gmail.com>
@yusufhm yusufhm self-requested a review August 21, 2023 04:28
@yusufhm yusufhm merged commit 083700f into salsadigitalauorg:master Aug 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling of GraphQL responses with error keys
3 participants