Allow any key as compose key #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e used as the compose key.
Elyviere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hard-coded requirements that allows only certain keys to be set as compose keys. Any key can now be set as the compose key, allowing for greater user flexibility in choosing an appropriate compose key.
I've tested the code locally by compiling an installer and installing it (on windows only). I couldn't find any issues with it, so no further tweaks seemed necessary. Potential useful addition would be to give a warning when setting a letter key (e.g. 'A') as a compose key, as it makes little sense and blocks the use of a necessary key. However, it's an obvious enough problem that the user can simply change the compose key once they realise the problem.