Delete PermissionTemplate when destroying a Hyrax::AdministrativeSet or Hyrax collection #6917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6916
Summary
Adds a workflow step to destroy the associated
PermissionTemplate
when destroying aHyrax::AdministrativeSet
or Hyrax collection.Type of change (for release notes)
notes-bugfix
Bug FixesDetailed Description
I couldn't find an exact analogue for this -- the closest was
DeleteAccessControl
transaction, so I modeled the behavior on that with a correspondingDeletePermissionTemplate
step. Note that the tests are a little more involved than the corresponding test forAdminSet
, as I found there werePermissionTemplate
records being created by side effect during the transaction call (e.g. creating the defaultAdministrativeSet
, while checking to make sure theAdministrativeSet
we're deleting wasn't it). I didn't want to mess with that behavior, but I'm open to suggestions about ways to make the tests cleaner.Changes proposed in this pull request:
AdminSetDestroy
andCollectionDestroy
now destroy the associatedPermissionTemplate
along with theAdministrativeSet
or collection.@samvera/hyrax-code-reviewers