Clean up observer interfaces #1087
Merged
+273
−526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperego
approved these changes
Nov 6, 2024
| std::size_t value_width = precision + 7; | ||
| *out << std::scientific << std::showpoint << std::setprecision(precision) << std::left; | ||
|
|
||
| // Note that we don't have g_names support in thyra yet. Once |
| } | ||
| } | ||
| *out << "\n"; | ||
| if (not firstResponseObtained and calculateRelativeResponses) { |
There was a problem hiding this comment.
what are these relative responses?
There was a problem hiding this comment.
I don't really know. I just re-arranged/fixed existing code here...
|
I merged so I can take care of any failure we may get tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observers have lots of interfaces, depending on how they are called (e.g., with/without xdot/xdotdot, with Vector's vs a MultiVector, etc). Rather than having lots of XYZimpl functions, try to make all the interfaces call a single impl function. This makes modifications of actual implementation easier, since we only have to mod one fcn.
As a side note: I think I would remove all the MultiVector interfaces in the discretization: as I did in one of the observers, the interface that takes a MultiVector (consisting of x, possibly xdot, possibly xdotdot) can simply extract the MV columns, and call the proper interface with Vector's. This would reduce the amount of interfaces we need to implement in our classes. But that's just a wishlist thought.