fix(cli): prevent crash when no package.json found in studio folder #7220
+50
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have the following folder structure:
Running
sanity dev
,sanity build
orsanity deploy
from withinstudios/studio-1
will currently crash, because we attempt to readpackage.json
from the "work directory", which is resolved tostudios/studio-1
.The folder structure does make sense, since you may want to reuse the same dependencies for multiple studios.
Additionally, if you happen to be missing required dependencies (
styled-components
), it will install to the studio folder, not the "dependency root" (eg in folder containingpackage.json
). Attempted to fix this too.Marked as draft since I have yet to write tests.
What to review
Testing
Notes for release