[vmware] VmdkDriverRemoteApi: RPC initialization improvements #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusleu
force-pushed
the
fix-remote_api-instance
branch
from
a93bc71
to
04edead
Compare
Currently, creating the RPC client at the driver initialization might lead into an issue that, while upgrading to newer releases, the RPC client will limit the maximum RPC version to the older release's version, since that version is never refreshed while the volume backend is running. Initializing the RPC client every time it's needed will make sure it always refreshes the available RPC service versions. Also, inherit the RPC_DEFAULT_VERSION from the VolumeAPI, so that the smallest available major version is requested by default, instead of the biggest available version.
mariusleu
force-pushed
the
fix-remote_api-instance
branch
from
04edead
to
8c1ec22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, creating the RPC client at the driver initialization
might lead into an issue that, while upgrading to newer releases,
the RPC client will limit the maximum RPC version to the older
release's version, since that version is never refreshed while the
volume backend is running. Initializing the RPC client every time
it's needed will make sure it always refreshes the available
RPC service versions.
Also, inherit the RPC_DEFAULT_VERSION from the VolumeAPI, so that
the smallest available major version is requested by default,
instead of the biggest available version.