chore: (IAC-1195) Update Branch Selector for GitHub Workflow #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
changed the title
thpang
reviewed
Nov 6, 2023
| @@ -1,7 +1,7 @@ | |||
| name: Linter Analysis | |||
| on: | |||
| push: | |||
| branches: [ '*' ] # '*' will cause the workflow to run on all commits to all branches. | |||
| branches: [ '**' ] # '**' will cause the workflow to run on all commits to all branches, including those with path separators | |||
There was a problem hiding this comment.
Guessing this is based on the new foo/bar-branch naming convention?
There was a problem hiding this comment.
That's correct, changing it to branches: [ '**' ] allows for the workflow to be automatically run again foo/bar-branch naming convention as well those without forward slashes , foo-bar-branch
thpang
approved these changes
Nov 6, 2023
riragh
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the branch selector for the GitHub workflow to allow it to additionally run against branches that use the path pattern (e.g. "fix/IAC-111").
Tests
The name of the source branch of this PR uses the path pattern
chore/IAC-1195and the GitHub workflow was automatically run.