Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-1312) Update Dependencies to Resolve Security Warnings #203

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Jan 23, 2024

Changes

Updates 3rd party dependencies in this project to resolve security findings from our scanning tool. Consumers of the Dockerfile will automatically have these updated dependencies installed, and users who directly run this project on this host will need to update the dependencies themselves. A note in the release notes will be made about this.

Version Updates

Here is a summary of version updates as well as code changes that needed to be made as result of the update.

Binaries

  • Terraform 1.4.5 -> 1.7.0
  • gcloud CLI 440.0.0 -> 460.0.0

Providers

hashicorp/google & hashicorp/google-beta
hashicorp/kubernetes
hashicorp/null
hashicorp/random
hashicorp/local
hashicorp/external
hashicorp/time

Modules

terraform-google-modules/kubernetes-engine/google//modules/private-cluster
GoogleCloudPlatform/sql-db/google//modules/postgresql
terraform-google-modules/service-accounts/google
terraform-google-modules/address/google
terraform-google-modules/cloud-nat/google

Note: Although the versions have been bumped up, there are no breaking changes. A user could still modify their infrastructure they created with viya4-iac-gcp:5.0.0 with this latest release provided that they update their deps with terraform init -upgrade (a note will be included in the release notes)

Tests

Scenario Provider kubernetes_version order cadence notes
1 GCP v1.27.9-gke.1092000 ****** fast:2020 OOTB deployment
2 GCP v1.27.9-gke.1092000 N/A N/A Initial infra create with 5.0.0 and modification with PR code
3 GCP v1.27.9-gke.1092000 ****** fast:2020 Initial infra create with 5.0.0 and Viya deployment, stop Viya deployment, node adjustment with PR code, and resume Viya deployment

@jarpat jarpat added the enhancement New feature or request label Jan 23, 2024
@jarpat jarpat self-assigned this Jan 23, 2024
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for information on my comment.

versions.tf Outdated Show resolved Hide resolved
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - IAC/DAC team should discuss version standards across providers

versions.tf Outdated Show resolved Hide resolved
@jarpat jarpat merged commit 4cfcd5d into staging Jan 29, 2024
3 checks passed
@jarpat jarpat deleted the IAC-1312 branch January 29, 2024 19:28
@jarpat jarpat mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants