Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NavLink instead for navigation links #21

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

tr1ms
Copy link
Contributor

@tr1ms tr1ms commented Oct 24, 2022

Fixes:

Screenshots and screen captures:

About us - Introduction #4

Screenshot from 2022-10-24 21-07-58

About us - essentials #3

Screenshot from 2022-10-24 21-08-08

Self-review checklist

  • [Self-reviewed](coming soon) the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see [commit discipline](coming soon)).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for savannahsilica ready!

Name Link
🔨 Latest commit c4888d5
🔍 Latest deploy log https://app.netlify.com/sites/savannahsilica/deploys/6356d8955bf8f60008ba581c
😎 Deploy Preview https://deploy-preview-21--savannahsilica.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@amoskyalo amoskyalo merged commit 520d938 into savannah-Silica:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants