Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Added Text.Append and Text.GetLength functions #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Text.Append and Text.GetLength functions #50

wants to merge 1 commit into from

Conversation

abhi-shukla
Copy link

No description provided.

OmarTawfik
OmarTawfik approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Can you also do a sanity check (screenshot) of the editor using these methods?
We currently don't have automated integration tests for that :(

@abhi-shukla
Copy link
Author

abhi-shukla commented Oct 30, 2018 •
edited
Loading

Hope this validates my claims :) @OmarTawfik

image

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhi-shukla @OmarTawfik