adds missing clock properties #51

anuragpeshne · 2018-10-27T04:37:57Z

have a look at the test regex. Would it better to get current time values and then compare?

OmarTawfik · 2018-10-27T06:04:23Z

src/compiler/runtime/libraries/dictionary.ts

@@ -0,0 +1,8 @@
+import { LibraryTypeInstance, LibraryMethodInstance, LibraryPropertyInstance, LibraryEventInstance } from "../libraries";


Why are we adding this file?

It slipped through my notice. I'll amend my commit.

OmarTawfik · 2018-10-27T06:06:21Z

tests/compiler/runtime/libraries/clock.ts

@@ -11,7 +11,149 @@ x = Clock.Time`);
        engine.execute(ExecutionMode.RunToEnd);

        const value = engine.memory.values["x"];
-        expect(value.toValueString()).toMatch(/[0-9]{2}:[0-9]{2}:[0-9]{2}/);
+        expect(value.toValueString()).toMatch(/[0-9]{2}:[0-9]{2}:[0-9]{2} A|PM/);


It appears that adding the AM/PM made the tests fail. Why did we do that?

Strange. On the contrary, tests were failing on my system without it. Maybe it depends on the locale? In that case we should manually construct the string?

We can easily reproduce this, just try:
LANG=en_US node -e 'console.log((new Date()).toLocaleString())'

anuragpeshne requested a review from OmarTawfik October 27, 2018 04:37

OmarTawfik reviewed Oct 27, 2018

View reviewed changes

adds missing clock properties

fa5b649

anuragpeshne force-pushed the feature/add-clock-prop branch from 028f56c to fa5b649 Compare October 27, 2018 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds missing clock properties #51

adds missing clock properties #51

anuragpeshne commented Oct 27, 2018

OmarTawfik Oct 27, 2018

anuragpeshne Oct 27, 2018

OmarTawfik Oct 27, 2018 •

edited

Loading

anuragpeshne Oct 27, 2018

anuragpeshne Nov 5, 2018 •

edited

Loading

		@@ -0,0 +1,8 @@
		import { LibraryTypeInstance, LibraryMethodInstance, LibraryPropertyInstance, LibraryEventInstance } from "../libraries";

adds missing clock properties #51

Are you sure you want to change the base?

adds missing clock properties #51

Conversation

anuragpeshne commented Oct 27, 2018

OmarTawfik Oct 27, 2018

Choose a reason for hiding this comment

anuragpeshne Oct 27, 2018

Choose a reason for hiding this comment

OmarTawfik Oct 27, 2018 • edited Loading

Choose a reason for hiding this comment

anuragpeshne Oct 27, 2018

Choose a reason for hiding this comment

anuragpeshne Nov 5, 2018 • edited Loading

Choose a reason for hiding this comment

OmarTawfik Oct 27, 2018 •

edited

Loading

anuragpeshne Nov 5, 2018 •

edited

Loading