This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Add the Sound library #53
Open
sarajoiner
wants to merge
7
commits into
master
Choose a base branch
from
add-sound-library
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 30, 2018
-
Add basic structure for Sound library
Adds the basic structure for the Sound library, and populates it with the first couple (not yet implemented) methods.
Configuration menu - View commit details
-
Copy full SHA for 33411c2 - Browse repository at this point
Copy the full SHA 33411c2View commit details
Commits on Oct 31, 2018
-
Implementation of Sound.PlayClick
Implemented Sound.PlayClick and manually verified that it works!
Configuration menu - View commit details
-
Copy full SHA for e955419 - Browse repository at this point
Copy the full SHA e955419View commit details -
Add documentation for PlayClick
Adds the documentation for PlayClick.
Configuration menu - View commit details
-
Copy full SHA for 672526d - Browse repository at this point
Copy the full SHA 672526dView commit details -
Add strings for the rest of the Sound APIs
Adds the strings for the rest of the Sound APIs, as copied from SmallBasic.Web\Content\js\json\generated-output.json
Configuration menu - View commit details
-
Copy full SHA for 4afcdcb - Browse repository at this point
Copy the full SHA 4afcdcbView commit details -
Copy better strings into Sound.Play and Sound.Play.FilePath, per the actual documentation headers in the original code.
Configuration menu - View commit details
-
Copy full SHA for 26b4100 - Browse repository at this point
Copy the full SHA 26b4100View commit details -
Add structure for the rest of the Sound APIs
Implement the structure of the rest of the Sound APIs, + actually implement the three easy ones (playing sound files like what was already implemented for Click)
Configuration menu - View commit details
-
Copy full SHA for 6bcc162 - Browse repository at this point
Copy the full SHA 6bcc162View commit details
Commits on Nov 1, 2018
-
Add unit tests for the Sound library
Refactor the Sound library to make it more unit testable, and add some basic tests.
Configuration menu - View commit details
-
Copy full SHA for 8e65ba2 - Browse repository at this point
Copy the full SHA 8e65ba2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.