Upgrade rubygem versions. #19716
Upgrade rubygem versions. #19716
Conversation
yilinwei
force-pushed
the
spec-changes
branch
from
53b45df
to
578aac1
Compare
yilinwei
force-pushed
the
spec-changes
branch
from
2502cdf
to
ee3c932
Compare
yilinwei
force-pushed
the
spec-changes
branch
from
ee3c932
to
9e568ed
Compare
| const start = match.index; | ||
| match = re.exec(text); | ||
| if(match == null) { | ||
| break; |
There was a problem hiding this comment.
There is a weird mix of tabs and spaces here. The surrounding code uses 2 spaces for indentation of JavaScript code. We should stick to that.
There was a problem hiding this comment.
Will - do I am going through each bit of the snippets first to make sure the rendering works from before. I will unmark as draft and untabify once it's done.
docs/_spec/Dockerfile
Outdated
There was a problem hiding this comment.
Changes in this file should be reflected at https://github.com/lampepfl/dotty/blob/ca88156789b2c94f107f85f07b238a59d84b7d65/.github/workflows/spec.yml#L26-L37 as well. I guess we should add a comment in the current file warning about this.
…thub workflows (#19718) Currently the local server for the spec fails to build with the same issue as in #19288 on a fresh docker build. This is the minimum amount of changes to actually get the spec building for users to make changes. I highly recommend updating all the versions when #19716 is finished.
|
I've noticed this is based on a very old branch (previous commit is from September 2023), do you mind rebasing? |
|
The latex handling also only seems to be working in specific places, e.g. only one 
for comparison with the current deployed docs: 
|
|
Yup, I have a local branch which is in-progress and I'll undraft/rebase this once it's done. Basically I don't deal with the case where the backtick extends across multiple highlight spans (I deal with the inverse, where one span contains multiple backtick expansions). Some of issues here are also because it infers the wrong language as well - for some reason it really likes to infer as perl... |
|
That is quite tricky. Perhaps your other idea of escaping the backticks at build time makes more sense? Maybe each backtick is subbed by (I have no idea how this works for disclaimer) |
|
I'd love that to be that simple, but we backtick across delimiters such as I have some time to look at this, this weekend and I think that it's pretty much there on my own local branch. |
awesome, thanks! |
2.7to3.3since2.7is eol.4.3.3since3.xis only supporting maintenance fixes at this point.redcarpetsince jekyll has dropped support for it.GemfileNotes
Syntax highlighting
We don't use Jekyll's syntax highlighting (rouge) at all. As far as I can tell this is due to:
Because we embed math elements into the snippets - something more complicated like using the
tree-sitter-based grammar is a no-go; it is not nearly permissive enough to deal with what we're doing. We could use a strategy like replacing the math elements with placeholder identifiers (making sure to respect Scala's naming rules) and substitute them back in - but treesitter doesn't support EBNF either, which is a large part of the spec.However since highlight-js has removed support for this feature, we could potentially look at doing this server-side or using rouge. This has the added benefit that it would be more inline with Github's own syntax highlighting I think. Since I don't know ruby or rouge at all, I haven't done a thorough investigation of this option.
I do, on the other hand, know Javascript so I've added started to add the merge behaviour back in like before, so we can now upgrade the highlight.js version successfully.