Skip to content

impr(VLTCLT-68): Add getAccountLimitsByCanonicalIds wrapper for getAccounts - #469

Merged
bert-e merged 3 commits into
development/8.5from
improvement/VLTCLT-68/add_getAccountLimitsByCanonicalId
Aug 6, 2026
Merged

impr(VLTCLT-68): Add getAccountLimitsByCanonicalIds wrapper for getAccounts#469
bert-e merged 3 commits into
development/8.5from
improvement/VLTCLT-68/add_getAccountLimitsByCanonicalId

Conversation

@tmacro

@tmacro tmacro commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bert-e

bert-e commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Jul 31, 2026
@tmacro
tmacro force-pushed the improvement/VLTCLT-68/add_getAccountLimitsByCanonicalId branch from 95fd997 to 8ab0e77 Compare July 31, 2026 17:05
@bert-e

bert-e commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Jul 31, 2026

@anurag4DSB anurag4DSB left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but added a comment which might be too late for development cycle.

Comment thread lib/IAMClient.d.ts
* and the error, if there is one
* @returns {undefined}
*/
getAccountLimitsByCanonicalIds(canonicalIds: string[], options: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be too late for this comment:
Are we gonna support more types of limits other than rate limit.
Limits might confuse the end user/admin, getAccountRateLimitByCanonicalIds might be more descriptive.

Comment thread lib/IAMClient.js
'the account name, if set, should be a string');
data.AccountName = accountName;
}
'limits must be an object');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be too late here as well, rate limit instead of limits

@tmacro

tmacro commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.5

The following branches have NOT changed:

  • development/6.4
  • development/7
  • development/7.10
  • development/7.4
  • development/8.2
  • development/8.3
  • development/8.4

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/7.10.0
  • hotfix/7.4.4
  • hotfix/7.4.5
  • hotfix/7.8.0
  • hotfix/7.4.3
  • hotfix/7.7.0
  • hotfix/7.10.2
  • hotfix/7.4.7
  • hotfix/7.10.8
  • hotfix/7.10.13
  • hotfix/7.4.2
  • hotfix/7.10.3
  • hotfix/7.9.0
  • hotfix/7.4.6
  • hotfix/7.6.0
  • hotfix/7.4.1
  • hotfix/7.4.9
  • hotfix/6.4.7
  • hotfix/7.10.1
  • hotfix/7.10.4
  • hotfix/7.2.0
  • hotfix/7.4.10
  • hotfix/7.4.8
  • hotfix/7.4.0

Please check the status of the associated issue VLTCLT-68.

Goodbye tmacro.

The following options are set: approve

@bert-e
bert-e merged commit 8ab0e77 into development/8.5 Aug 6, 2026
1 check passed
@bert-e
bert-e deleted the improvement/VLTCLT-68/add_getAccountLimitsByCanonicalId branch August 6, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants