impr(VLTCLT-68): Add getAccountLimitsByCanonicalIds wrapper for getAccounts - #469
Conversation
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
95fd997 to
8ab0e77
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
anurag4DSB
left a comment
There was a problem hiding this comment.
Approving this, but added a comment which might be too late for development cycle.
| * and the error, if there is one | ||
| * @returns {undefined} | ||
| */ | ||
| getAccountLimitsByCanonicalIds(canonicalIds: string[], options: { |
There was a problem hiding this comment.
may be too late for this comment:
Are we gonna support more types of limits other than rate limit.
Limits might confuse the end user/admin, getAccountRateLimitByCanonicalIds might be more descriptive.
| 'the account name, if set, should be a string'); | ||
| data.AccountName = accountName; | ||
| } | ||
| 'limits must be an object'); |
There was a problem hiding this comment.
may be too late here as well, rate limit instead of limits
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue VLTCLT-68. Goodbye tmacro. The following options are set: approve |
No description provided.