bf(VLTCLT-67): Fix validation and add unit tests - #470
Merged
bert-e merged 3 commits intoAug 6, 2026
Merged
Conversation
tcarmet
approved these changes
Jul 31, 2026
anurag4DSB
approved these changes
Aug 3, 2026
Base automatically changed from
improvement/VLTCLT-68/add_getAccountLimitsByCanonicalId
to
development/8.5
August 6, 2026 20:38
Contributor
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue VLTCLT-67. Goodbye tmacro. The following options are set: approve |
bert-e
deleted the
improvement/VLTCLT-67/fix_accountAttribute_validation
branch
August 6, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation in update/deleteAccountAttributes contains an extra set of
()causing the expression to always eval totrue;