Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private endpoints and update versions to be alligned with SCEPman 2.8 #18

Conversation

Utesgui
Copy link
Collaborator

@Utesgui Utesgui commented May 7, 2024

  • add private endpoints to storage + kv
  • add vnet-integration to app(s)
  • adjust networking + rules
  • block external access
  • switch to .net v8.0
  • upgrade provider version
  • update Readme + advanced example

@Utesgui Utesgui requested a review from bb-froggy May 8, 2024 06:44
@bb-froggy
Copy link
Member

IP-Ranges

In the current code in the PR, the VNET has 10.255.255.0/24 by default with the two subnets 10.255.255.0/25 and 10.255.255.128/25. The ARM-Template originally used the 10.0.0.0/16 IP range for the VNET. Although there is usually no need to connect the VNET to any other network, Azure checks for collisions even with unconnected VNETs, so it now uses the more random 10.142.0.0/16.

I suggest to have the TF default also use a more random VNET IP range like 10.158.200.0/24 for the VNET.

I further suggest to not assign the whole address space to existing Subnets and leave some IPs for additional subnets possibly needed in the future. Although there are no specific plans for this, it is the case for the ARM deployment and if it is ever needed, we might want to other Subnets in the existing IP range. I suggest we use 3 instead of 1 bit for the prefix, leaving 5 bit for the subnet with 32-2=30 IPs in each subnet by default.

Everything else

Looks good so far, but I will do some testing.

@bb-froggy bb-froggy merged commit 7611d04 into scepman:main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants