I387 set is child default value #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default value of is_child to true.
…tead we set the is_child property to true in the iiif_print gem.
|
Nice, that looks good! |
kirkkwang
approved these changes
May 12, 2023
laritakr
added a commit
that referenced
this pull request
May 17, 2023
- This did not do what was needed because the config is not used in recent works searches, and the solr field would have needed to be set for it to do anything anyway. This repo does not use the default. - Desired feature was implemented by #411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
iiif_print ref: scientist-softserv/iiif_print#237
Refs #387
Story
This PR is to address the feedback from the following ticket. The user was still able to see the child works in the recent works catalog and recent works section, while they were processing. This is because they weren't getting filtered out until the relationship job are formed, and the is_child property was set.
To resolve this, we are setting the child work is_child attribute to be true on default in iiif_print. So this PR updates the gem to pull in the fix.
Refs #387
Expected Behavior Before Changes
ref: #387 (comment)
Expected Behavior After Changes
As a result, you cannot see the child records while it's still processing. The user should and does not see child works in the following scenarios:
EMPTY CATALOG SEARCH :
RECENT WORKS SECTION:
VIEW RECENT ADDITIONS CATALOG PG:
Sidekiq
Notice is_child property is being set to true in the CreateWorkJob:
sample work: service-rbc-rbc0001-2015-2015gen56010-2015gen56010.pdf
Notes