fix: legend linestyle for step histogram (#496)

* forward linestyle to _e_leg and remove xerr * fix exception if no linestyle is given * update test
scikit-hep · Apr 30, 2024 · f6c9542 · f6c9542
1 parent 57d95c8
commit f6c9542
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/mplhep/plot.py b/src/mplhep/plot.py
@@ -416,14 +416,15 @@ def iterable_not_string(arg):
 
             if do_errors:
                 _kwargs = soft_update_kwargs(_kwargs, {"color": _s.get_edgecolor()})
+                _ls = _kwargs.pop("linestyle", "-")
                 _kwargs["linestyle"] = "none"
                 _plot_info = plottables[i].to_errorbar()
                 _e = ax.errorbar(
                     **_plot_info,
                     **_kwargs,
                 )
                 _e_leg = ax.errorbar(
-                    [], [], yerr=1, xerr=1, color=_s.get_edgecolor(), label=_label
+                    [], [], yerr=1, xerr=None, color=_s.get_edgecolor(), label=_label, linestyle=_ls
                 )
             return_artists.append(
                 StairsArtists(

diff --git a/tests/test_mock.py b/tests/test_mock.py
@@ -56,7 +56,8 @@ def test_simple(mock_matplotlib):
         approx([]),
         approx([]),
         yerr=1,
-        xerr=1,
+        xerr=None,
+        linestyle='-',
         color=ax.stairs().get_edgecolor(),
         label="X",
     )