Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Alpine Linux #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Switch to Alpine Linux #56

wants to merge 3 commits into from

Conversation

gsfr
Copy link
Member

@gsfr gsfr commented Apr 28, 2017

docker pull scitran/reaper:alpine

@gsfr gsfr requested a review from ryansanford April 28, 2017 03:04
@ryansanford
Copy link
Contributor

@gsfr I'd rather not support both alpine and buildpack base images. Does this PR take prescience over #55 ?

@gsfr
Copy link
Member Author

gsfr commented Apr 28, 2017

I agree in principal. However, I'd say #55 is low risk and should be merged immediately.

I'll test this Alpine image at the CNI and then we can make a decision for how to move forward.

ryansanford
ryansanford approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@ryansanford ryansanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no longer participating in this repo. Adding this approval so it no longer shows on my "waiting approval" list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansanford ryansanford ryansanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfr @ryansanford